prevent the keyboard follow the camera #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves #1 I don't know if moving the keyboard is a usecase some people want (i Don't) but if so, I think a better solution would be to setup the keyboard position as a parameter when initializing the keyboard. what do you think?
|
Hey, thanks so much for the PR! The problem I see with your implementation is that the keyboard is always shown in the same position, no matter where I am currently looking. This might cause the keyboard to show up behind me. A possible solution would be to set the surface's angle once, when the keyboard is shown, and then not update afterwards. |
|
ok that sounds reasonable!. let me change that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #1
I don't know if moving the keyboard is a usecase some people want (i Don't) but if so, I think a better solution would be to setup the keyboard position as a parameter when initializing the keyboard.
what do you think?